On Sun, Jun 3, 2018 at 11:14 AM, Duy Nguyen <pclo...@gmail.com> wrote:
> On Sun, Jun 3, 2018 at 10:16 AM, Eric Sunshine <sunsh...@sunshineco.com> 
> wrote:
>> On Sat, Jun 2, 2018 at 12:32 AM, Nguyễn Thái Ngọc Duy <pclo...@gmail.com> 
>> wrote:
>>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclo...@gmail.com>
>>> -               fprintf(stderr, "Could not apply %s... %.*s\n",
>>> +               fprintf_ln(stderr, _("Could not apply %s... %.*s"),
>>
>> Did you want to downcase "Could" for consistency with other error
>> messages, or was this left as-is intentionally?
>
> I'm not sure. Others start with a prefix (like "error:",
> "warning:"....). This is a bit different and makes me hesitate.

Yep, I realized after hitting Send that this wasn't an error/warning
message so probably shouldn't be changed.

Reply via email to