On Thu, May 17, 2018 at 12:46 PM, Stefan Beller <sbel...@google.com> wrote: >>> * sb/diff-color-move-more (2018-04-25) 7 commits >>... >>> >>> Will merge to 'next'. >> >>I did not get around to fix it up, there are still review >>comments outstanding. (The test is broken in the last commit.) > > This is a reroll of sb/diff-color-move-more, with the test fixed as well > as another extra patch, that would have caught the bad test. > > The range diff is below. > > Thanks, > Stefan > > Stefan Beller (8): > xdiff/xdiff.h: remove unused flags > xdiff/xdiffi.c: remove unneeded function declarations > diff.c: do not pass diff options as keydata to hashmap > diff.c: adjust hash function signature to match hashmap expectation > diff.c: add a blocks mode for moved code detection > diff.c: decouple white space treatment from move detection algorithm > diff.c: add --color-moved-ignore-space-delta option > diff: color-moved white space handling options imply color-moved >
I've been using this locally, and it's really nice. One question I had, are there plans to make the whitespace options configurable? I really like the option for enabling lines to count as moved when the whitespace changes uniformly, (it helps make changes more obvious when doing indentation changes such as wrapping code within a block). However, it's rather a long option name to type out. I didn't see any obvious config options to enable it by default though. Thanks, Jake
