Eric Sunshine <sunsh...@sunshineco.com> writes: > A couple comments if you happen to re-roll... > > On Wed, Jun 13, 2018 at 10:22 AM Jeremy Linton <lintonrjer...@gmail.com> > wrote: >> The buffer being passed to zlib includes a null terminator that > > On this project, the character mnemonic "NUL" is typically used, not > "null" or "NULL" (which is typically reserved for pointers), so: > s/null/NUL/g
Correct but I did not think it is a per-project preference; rather, "NUL is the name of the byte" is universal ;-) >> diff --git a/packfile.c b/packfile.c >> @@ -1433,6 +1433,8 @@ static void *unpack_compressed_entry(struct packed_git >> *p, >> + buffer[size] = 0; /* assure that the buffer is still terminated */ > > I think we normally use '\0' for NUL on this project rather than simply 0. > > The comment is also effectively pure noise since it merely repeats > what the code already states clearly (especially when the code says > "buffer[size] = '\0';"), so dropping the comment altogether would be > reasonable. Both are sensible suggestions. Thanks for making them.
