On Sat, Jan 5, 2013 at 10:20 PM, Nguyễn Thái Ngọc Duy <pclo...@gmail.com> wrote: > + > + /* No arguments, no prefix -> no pathspec */ > + if (!entry && !prefix) > + return; > > + /* No arguments with prefix -> prefix pathspec */
When working with the old get_pathspec(), I remember wondering if a flag switching between "no argument -> prefix pathspec" and "no argument -> no pathspec" would be worthwhile. I think e.g. 'add' and 'clean' would use the former , while 'reset' and 'commit' would use the latter. Since you're now changing all the callers of get_pathspec(), it seems like the perfect time to ask this question. What do you think? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
