Hi,
Junio C Hamano wrote:
> Todd Zullinger <t...@pobox.com> writes:
>
>> Hi Johannes,
>>
>> Johannes Schindelin via GitGitGadget wrote:
>>> From: GitGitGadget <gitgitgad...@gmail.com>
>>>
>>> Todd Zullinger reported this bug in
>>> https://public-inbox.org/git/20180615043111.gs3...@zaya.teonanacatl.net/:
>>> when calling git rebase --root and trying to reword the
>>> root commit's message, a BUG is reported.
>>>
>>> This fixes that.
>>>
>>> IMO the bug fix is trivial enough to qualify for inclusion into v2.18.0,
>>> still.
>>
>> It does indeed fix the issue. I agree it would be nice to
>> see it in 2.18.0. As a fix for a minor regression
>> introduced in this cycle, that seems reasonable.
>
> Offhand it is not clear from the proposed log message where the
> original breakage happened, but if this is to fix a regression
> between v2.17.0 and v2.18.0, then let's have it. As -rc2 slipped
> for a few days, it is reasonable to delay the final by a couple of
> days as well, if only to give the last minute fixes and translators
> reasonable time to breathe.
Perhaps replacing the first paragraph with this would make
it clearer?
Since 21d0764c82 ("rebase -i --root: let the sequencer handle even the
initial part", 2018-05-04), when splitting a repository, running `git
rebase -i --root` to reword the initial commit, Git dies with
Alternately, a similar note could be added at the end.
This regression was recently introduced in 21d0764c82 ("rebase -i
--root: let the sequencer handle even the initial part", 2018-05-04).
--
Todd
