On 06/15, Junio C Hamano wrote: > Brandon Williams <bmw...@google.com> writes: > > > Changes in v2: > > * issuing a want-ref line to a ref which doesn't exist is just ignored. > > * fixed some typos > > Do I lock some (logical) prerequisite changes? On 2.18-rc2 they > apply cleanly but the series fails its own test.
No this is an error I made in this version of the series which another reviewer pointed out, I have a local v3 which addresses this (by removing the test since it isn't necessary anymore). Sorry for the mistake :) > > t5703-upload-pack-ref-in-want.sh > expecting success: > test-pkt-line pack >in <<-EOF && > command=fetch > 0001 > no-progress > want-ref refs/heads/non-existent > done > 0000 > EOF > > test_must_fail git serve --stateless-rpc 2>out <in && > grep "unknown ref" out > > test_must_fail: command succeeded: git serve --stateless-rpc > not ok 3 - invalid want-ref line -- Brandon Williams
