On Mon, Jun 18, 2018 at 11:30 AM, Stefan Beller <sbel...@google.com> wrote: >> +test_expect_success 'fetch supports various ways of have lines' ' >> + rm -rf server client trace && > > Can we move these deletions to test_when_finished of the previous(?) test > as well as have them here in a test_when_finished line?
I think that deleting them when necessary makes it more explicit, and this also supports tests where a repository is set up and then used over multiple tests (e.g. having separate "setup X" and "use X" tests). > This test is precise and easy to understand; the patch is > Reviewed-by: Stefan Beller <sbel...@google.com> > (considering the test_when_finished comment as > an optional nit) Thanks. Do you have any comments about the performance issue that Brandon brought up?
