On Mon, Jul 2, 2018 at 2:27 PM Stefan Beller <sbel...@google.com> wrote: > On Sun, Jul 1, 2018 at 5:24 PM Eric Sunshine <sunsh...@sunshineco.com> wrote: > > This series fixes several buggy tests which went undetected due to > > broken &&-chains in subshells, modernizes some tests to take advantage > > of test functions (test_might_fail(), test_write_lines(), etc.), and > > fixes a lot of broken &&-chains in subshells. [...] > > I think it is good to include it as is and build on top if needed. I had some > comments on the earlier part of the series, but that is really just the cherry > on top of the cake.
Thanks for the review comments.
