Hi Pratik, On Fri, 6 Jul 2018, Pratik Karki wrote:
> The functions present in `git-legacy-rebase.sh` are used by the rebase > backends as they are implemented as shell script functions in the > `git-rebase--<backend>` files. > > To make the `builtin/rebase.c` work, we have to provide support via > a Unix shell script snippet that uses these functions and so, we > want to use the rebase backends *directly* from the builtin rebase > without going through `git-legacy-rebase.sh`. > > This commit extracts the functions to a separate file, > `git-rebase--common`, that will be read by `git-legacy-rebase.sh` and > by the shell script snippets which will be used extensively in the > following commits. Good. While this seems to catch all the functions required by the backends, I am fairly certain that the `resolvemsg` variable is used exclusively by the backends, and it should therefore also moved into `git-rebase--common`. See my comments on your https://github.com/git/git/pull/505 for more details. Ciao, Dscho
