On Mon, Jul 09, 2018 at 09:48:55PM +0300, Daniel Harding wrote: > Hello brian, > > On Mon, 09 Jul 2018 at 00:02:00 +0300, brian m. carlson wrote: > > Should this affect the "# Merge the topic branch" line (and the "# C", > > "# E", and "# H" lines in the next test) that appears below this? It > > would seem those would qualify as comments as well. > > I intentionally did not change that behavior for two reasons: > > a) from a Git perspective, comment characters are only effectual for > comments if they are the first character in a line > > and > > b) there are places where a '#' character from the todo list is actually > parsed and used e.g. [0] and [1]. I have not yet gotten to the point of > grokking what is going on there, so I didn't want to risk breaking something > I didn't understand. Perhaps Johannes could shed some light on whether the > cases you mentioned should be changed to use the configured commentChar or > not.
Fair enough. Thanks for the explanation. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204
signature.asc
Description: PGP signature
