On Wed, Jul 11, 2018 at 07:26:19PM +0200, SZEDER Gábor wrote:

> > But it is really "make sure that a failed test here does not prevent us
> > from doing this cleanup". So the original really should have just
> > dropped that comment and added a test_when_finished. Bumping it into a
> > separate test as you have here accomplishes the same thing.
> 
> After taking a step back, I think this would fit better into the first
> patch, wouldn't it?
> I will send v3 shortly.

Yeah, I agree it would be even nicer to clean it up there.

-Peff

Reply via email to