Junio C Hamano <gits...@pobox.com> writes: > If I am reading the body of this if() block correctly, I think it > does everything init_revisions_and_shortrevisions shell function > does, i.e. compute $revisions for both cases with or without > upstream and write squash-onto state if needed, so that we can call > the sequencer_make_script() helper with necessary $revisions arg > without being passed from the command line of --make-script helper. > > But the hunk below tells me that you are still calling > init_revisions_and_shortrevisions shell function before we are > called. Why? IOW, why isn't this step removing that shell function > *and* the call to it, now its logic is fully implemented in the body > of this if() block?
You can ignore this part (but not the rest) of my comments, as 13/13 answers it adequately. After this step, the shell function still needs to be called to set $shortrevisions. Thanks.
