On Mon, Jul 30, 2018 at 11:47 AM Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > On Mon, 30 Jul 2018, Eric Sunshine wrote: > > Unfortunately, after sending this series, I see that there is > > additional corruption that needs to be addressed. In particular, the > > "author" header time is incorrectly prefixed with "@", so this series > > is going to need a re-roll to fix that, as well. > > AFAIR the `@` was not an oversight, but required so that we could pass in > the Unix epoch.
I don't think it was an oversight either, but it is nevertheless incorrect to use the "@" in the commit object's "author" header. As I understand it, you do "need" the "@" to distinguish a Unix epoch value assigned to GIT_AUTHOR_DATE, but the commit object format is very exacting in the datestamp format it accepts, and it does not allow "@". So, the date from GIT_AUTHOR_DATE needs to be converted to a format acceptable to the commit object, otherwise the commit is considered corrupt.
