Eric Sunshine <sunsh...@sunshineco.com> writes: > I think this patch can be simplified considerably by shifting one's > perspective. If we admit that read_author_ident() is already correctly > reporting an error by returning NULL (which is exactly what it is > doing), then the bug is is purely on the calling side; namely, the > caller is ignoring the error. (In fact, your commit message already > states this.)
This approach looks quite sensible.
