Hi Ramsay and Peff, On Sun, Aug 12, 2018 at 3:16 AM, Jeff King <p...@peff.net> wrote: > On Sun, Aug 12, 2018 at 01:30:02AM +0100, Ramsay Jones wrote: > >> My static-check.pl script has pinged me about the get_delta_base() >> symbol from packfile.[co]. The first patch from your 'cc/delta-islands' >> branch exports this symbol, saying that it will soon be called from >> outside packfile.c. As far as I can tell, no other patch in that series >> adds any such call.
Yeah, I should have checked that but I didn't. Thanks for noticing. >> Do you have plans to extend that series with additional patches which >> will add such calls? > > Hmm, I think this is just my error. I had to untangle the delta island > code from a few other topics, and I think I mistakenly attributed the > need for get_delta_base() to the wrong topic. It can just be left alone > for this series. Ok, I will will remove the first patch in the next reroll. Thanks.
