On Sun, Aug 19, 2018 at 1:54 PM brian m. carlson <sand...@crustytoothpaste.net> wrote: > Adjust the test so that it computes variables for object IDs instead of > using hard-coded hashes.
Nit: s/hashes/hash values/ > Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> > --- > diff --git a/t/t0002-gitfile.sh b/t/t0002-gitfile.sh > @@ -92,11 +92,12 @@ test_expect_success 'enter_repo non-strict mode' ' > ) && > + head=$(git -C enter_repo rev-parse HEAD) && > [...] > + cat >expected <<-EOF && > + $head HEAD > + $head refs/heads/master > + $head refs/tags/foo > EOF > test_cmp expected actual > ' Okay, but... > @@ -107,20 +108,20 @@ test_expect_success 'enter_repo linked checkout' ' > - [...] > + cat >expected <<-EOF && > + $head HEAD > + $head refs/heads/master > + $head refs/tags/foo > EOF > test_cmp expected actual > ' This is relying upon 'head' set inside an earlier test, which seems fragile. More robust would be to compute 'head' anew within each test which needs it (including the other new test added by this patch).
