On Mon, Sep 3, 2018 at 7:25 PM brian m. carlson
<[email protected]> wrote:
> Add several test functions to make working with various hash-related
> values easier.
> [...]
> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> @@ -1155,3 +1155,70 @@ depacketize () {
> +# Detect the hash algorithm in use.
> +test_detect_hash () {
> + test_hash_algo='sha1'
> +}
Not worth a re-roll itself, but if you do re-roll for some reason,
perhaps include a comment inside the function saying that the actual
"detect" part will be fleshed out later.
> +test_oid_cache () {
> + local tag reset k v
s/reset/rest/
It probably wouldn't hurt to &&-chain the above, as well, to
future-proof it against someone coming along and inserting code before
the 'local' line.
> + test -n "$test_hash_algo" || test_detect_hash &&
> + while read tag rest
> + do
> + case $tag in
> + [...]
> + esac &&
> +
> + k="${rest%:*}" &&
> + v="${rest#*:}" &&
> +
> + if ! expr "$k" : '[a-z0-9][a-z0-9]*$' >/dev/null
> + then
> + error 'bug in the test script: bad hash algorithm'
Did you want to redirect this to stderr like you do with error() in test_oid()?
> + fi &&
> + eval "test_oid_${k}_$tag=\"\$v\""
> + done
> +}
