Stefan Beller <sbel...@google.com> writes: > From some offline discussion, maybe we want to adapt a philosophy of > > Each patch needs to add a test, that fails when the patch > is not applied, but succeeds when it is applied. This shows > that _some_ code in the patch is exercised at least. > > (and automatically/strongly enforce this going forwards; however > enforcing such a strict thing is hard, not sure how we'd do it.)
Some patches lack test, but when one comes with a test, I do revert the code change and try to run the tests before I create a topic branch for it, when I have time. An enforcement mechanism may be good (e.g. submitGit could learn to do that "does it come with a test" check followed by "let's see if the new test fail without the change to the code part" before allowing the patch to escape to the list), but
