Stefan Beller <sbel...@google.com> writes: >> - init_revisions(revs, prefix); >> + init_revisions(revs, the_repository, prefix); > > Thanks for this patch! > > At first I wondered why we put the repository as the second argument, > but that comes down to personal preference, so I wanted to keep it silent. > (FWIW: Thinking about it, I'd either go with this order or with (repo, > prefix, revs)
FWIW, I would also find it more natural to have the_repository as the first parameter, for the same reason why the "index" functions (as opposed to "cache" convenience wrappers) have the_index as the first one.
