On Fri, Sep 7, 2018 at 8:21 PM Jeff King <p...@peff.net> wrote: > > We currently build cleanly with -Wformat-security, and it's > a good idea to make sure we continue to do so (since calls > that trigger the warning may be security vulnerabilities).
Nice. I had this flag in my config.mak too before switching to DEVELOPER=1. Didn't realize I lost the flag until now. > Signed-off-by: Jeff King <p...@peff.net> > --- > config.mak.dev | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/config.mak.dev b/config.mak.dev > index 9a998149d9..f832752454 100644 > --- a/config.mak.dev > +++ b/config.mak.dev > @@ -14,6 +14,7 @@ CFLAGS += -Wpointer-arith > CFLAGS += -Wstrict-prototypes > CFLAGS += -Wunused > CFLAGS += -Wvla > +CFLAGS += -Wformat-security Maybe keep it sorted -- Duy
