On Sat, Sep 29, 2018 at 07:21:36AM +0200, Duy Nguyen wrote: > On Fri, Sep 28, 2018 at 06:24:59PM +0200, SZEDER Gábor wrote: > > diff --git a/t/t1701-racy-split-index.sh b/t/t1701-racy-split-index.sh > > index fbb77046da..5dc221ef38 100755 > > --- a/t/t1701-racy-split-index.sh > > +++ b/t/t1701-racy-split-index.sh > > @@ -148,7 +148,7 @@ done > > > > for trial in $trials > > do > > - test_expect_failure "update the split index when a racily clean cache > > entry is stored only in the shared index $trial" ' > > + test_expect_success "update the split index when a racily clean cache > > entry is stored only in the shared index #$trial" ' > > The the new '#' before '$trial' intended?
Yes, they only cause troubles for 'prove' (or in the TAP output in general) in 'test_expect_failure', all the previous tests already have '#$trial', just like the related tests in 't0010-racy-git.sh'. And many more tests have '#' in their names: $ git grep 'test_expect_success.*#' master |wc -l 121 > > > rm -f .git/index .git/sharedindex.* && > > > > # The next three commands must be run within the same > > @@ -170,8 +170,6 @@ do > > # entry of racy-file is only stored in the shared index. > > # A corresponding replacement cache entry with smudged > > # stat data should be added to the new split index. > > - # > > - # Alas, such a smudged replacement entry is not added! > > git update-index --add other-file && > > > > # Subsequent git commands should notice the smudged > > @@ -182,7 +180,7 @@ done > > > > for trial in $trials > > do > > - test_expect_failure "update the split index after unpack trees() copied > > a racily clean cache entry from the shared index $trial" ' > > + test_expect_success "update the split index after unpack trees() copied > > a racily clean cache entry from the shared index #$trial" ' > > rm -f .git/index .git/sharedindex.* && > > > > # The next three commands must be run within the same > -- > Duy
