Jeff King <p...@peff.net> writes:
> Right, I'm proposing only to add the extra message and then continue as
> usual.
>
> It is a little funny, I guess, if you have a script which doesn't
> respond to "-h", because you'd get our "foo is aliased to git-bar"
> message to stderr, followed by who-knows-what. But as long as it's to
> stderr (and not stdout), I think it's not likely to _break_ anything.
>
>> > - "git cp --help" opens the manpage for cherry-pick. We don't bother
>> > with the alias definition, as it's available through other means
>> > (and thus we skip the obliteration/timing thing totally).
>>
>> It sounds like you suggest doing this unconditionally, and without any
>> opt-in via config option or a short wait? That would certainly work for
>> me. It is, in fact, how I expect 'git cp --help' to work, until I get
>> reminded that it does not... Also, as Junio noted, is consistent with
>> --help generally providing more information than -h - except that one
>> loses the 'is an alias for' part for --help.
>
> Yes, I'd suggest doing it always. No config, no wait.
While I do think your suggestion is the best among various ones
floated in the thread, I just realized there is one potential glitch
even with that approach.
Suppose "git foo" is aliased to a command "git bar".
The best case is when "git bar -h" knows that it is asked to give us
a short usage. We get "foo is aliased to bar" followed by the short
usage for "bar" and everything is visible above the shell prompt
after all that happens.
The second best case is when "git bar" simply does not support "-h"
but actively notices an unknown option on the command line to give
the usage message. We see "foo is aliased to bar" followed by "-h
is an unknown option; supported options are ..." and everything is
visible above the shell prompt after all that happens.
The worst case is when "git bar" supports or ignores "-h" and
produces reams of output. Sending the "aliased to" message to the
standard error means that it is scrolled out when the output is
done, or lost even when "git foo -h | less" attempts to let the
reader read before the early part of the output scrolls away.
Even the first two "better" cases share the same glitch if the "foo
is aliased to bar" goes to the standard error output. Parse-options
enabled commands tend to show a long "-h" output that you would need
to say "git grep -h | less", losing the "aliased to" message.
At least it seems to me an improvement to use standard output,
instead of standard error, for the alias information.
In practice, however, what the command that "git foo" is aliased to
does when given "-h" is probably unknown (because the user is asking
what "git foo" is in the first place), so perhaps I am worried too
much. When the user does not know if the usage text comes to the
standard output or to the standard error, and if the usage text is
very long or not, they probably would learn quickly that the safest
thing to do is to
$ git unknown-command -h >&2 | less
And at that point, it does not matter which between the standard
output and the standard error streams we write "unknown-command is
aliased to ...".
So I dunno.
