Hi Johannes, Thanks for putting this together, and offering to build Git on Azure Pipelines. I haven't followed v1 of this series very closely, so please excuse me if my comments have already been addressed, and I missed them in a skim of the last revision.
On Mon, Oct 15, 2018 at 03:11:57AM -0700, Johannes Schindelin via GitGitGadget wrote: > It is also an invaluable tool for contributors who can validate their code > contributions via PRs on GitHub, e.g. to verify that their tests do actually > run on macOS (i.e. with the BSD family of Unix tools instead of the GNU > one). Agree. > The one sad part about this is the Windows support. Travis lacks it, and we > work around that by using Azure Pipelines (the CI part of Azure DevOps, > formerly known as Visual Studio Team Services) indirectly: one phase in > Travis would trigger a build, wait for its log, and then paste that log. I wonder if Travis' recent announcement [1] affects this at all. To summarize [1], Travis is offering an early version of adding Windows to their list of supported builder operations systems. This brings the list to macOS, Linux, and Windows, which I think satisfies what we would like to regularly build git.git on. Would we like to abandon Travis as our main CI service for upstream git.git, and build on Azure Pipelines only? If so, I think that this is an OK way to go, but I think that I would be opposed to having more than one build system. (FWIW, we tend to _three_ for Git LFS, and it can be a hassle at times). I see some benefit to sticking with Travis, since we already have a build configuration that works there. But, you've done the work to "port" that build configuration over to Azure, so perhaps the point is moot. > As Git's Windows builds (and tests!) take quite a bit of time, Travis often > timed out, or somehow the trigger did not work, and for security reasons > (the Windows builds are performed in a private pool of containers), the > Windows builds are completely disabled for Pull Requests on GitHub. This would be a concession of [1], in my mind: is it possible to run the tests on Windows in a time such that Travis will not time out? > As a special treat, this patch series adds the ability to present the > outcome of Git's test suite as JUnit-style .xml files. This allows the Azure > Pipelines build to present fun diagrams, trends, and makes it a lot easier > to drill down to test failures than before. See for example > https://dev.azure.com/git/git/_build/results?buildId=113&view=ms.vss-test-web.test-result-details > [https://dev.azure.com/git/git/_build/results?buildId=113&view=ms.vss-test-web.test-result-details] > (you can click on the label of the failed test, and then see the detailed > output in the right pane). That's pretty cool. Travis doesn't support this (to the best of my knowledge). Thanks, Taylor [1]: https://blog.travis-ci.com/2018-10-11-windows-early-release
