In a272b9e70a ("urlmatch: allow globbing for the URL host part",
2017-01-31), we added support for wildcard matching for URLs when
reading from .git/config. Now it's possible to specify an option like
http.http://*.example.com/.cookieFile and have it match for the URL
http://foo.example.com. However, since this option also allows
wildcards at any level, the following also matches:
http.http://*.*.*/.cookieFile.I'm wondering if it was intentional to allow this behavior or if we intended to allow only the leftmost label (or labels) to be a wildcard. The tests seem to test only the leftmost label, and that is the behavior that one has for TLS certificates, for example. I don't really see a situation where one would want to match hostname labels in an arbitrary position, but perhaps I'm simply not being imaginative enough in thinking through the use cases. Regardless of what we decide, I'll be sending a patch, either to add additional tests, or correct the code (or both). I ask because we're implementing this behavior for Git LFS, where we don't iterate over all configuration keys, instead looking up certain values in a hash. We'll need to make some changes in order to have things work correctly if we want to implement the current Git behavior to prevent combinatorial explosion. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204
signature.asc
Description: PGP signature
