Jeff King wrote: > On Thu, Jan 24, 2013 at 03:07:42PM -0800, Junio C Hamano wrote[1]:
>> Instrument the completion script and give it a way for us to tell >> what (subset of) subcommands we are going to ship. [...] > The only thing I might add is a test just to double-check that "git help > -a" is parsed correctly. Like: > > test_expect_success 'command completion works without test harness' ' > GIT_TESTING_COMMAND_COMPLETION= run_completion "git bun" && > grep "^bundle\$" out > ' Yes. Since there are no other 'git help -a' tests, I think we need this. Aside from that, the fix looks good to me. Jonathan [1] http://thread.gmane.org/gmane.comp.version-control.git/214167/focus=214469 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
