This changes complete_action() to use edit_todo_list(), now that it can
handle the initial edit of the todo list.

Signed-off-by: Alban Gruin <alban.gr...@gmail.com>
---
 sequencer.c | 20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/sequencer.c b/sequencer.c
index f04b002e37..02afd2f5cd 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -4654,6 +4654,7 @@ int complete_action(struct replay_opts *opts, unsigned 
flags,
        struct todo_list new_todo = TODO_LIST_INIT;
        struct strbuf *buf = &todo_list->buf;
        struct object_id oid;
+       int res;
 
        get_oid(onto, &oid);
        shortonto = find_unique_abbrev(&oid, DEFAULT_ABBREV);
@@ -4679,24 +4680,15 @@ int complete_action(struct replay_opts *opts, unsigned 
flags,
                return error(_("nothing to do"));
        }
 
-       if (todo_list_write_to_file(todo_list, todo_file,
-                                   shortrevisions, shortonto, -1,
-                                   flags | TODO_LIST_SHORTEN_IDS | 
TODO_LIST_APPEND_TODO_HELP))
-               return error_errno(_("could not write '%s'"), todo_file);
-
-       if (copy_file(rebase_path_todo_backup(), todo_file, 0666))
-               return error(_("could not copy '%s' to '%s'."), todo_file,
-                            rebase_path_todo_backup());
-
-       if (launch_sequence_editor(todo_file, &new_todo.buf, NULL)) {
+       res = edit_todo_list(todo_list, &new_todo, shortrevisions, shortonto, 
flags);
+       if (res == -1)
+               return -1;
+       else if (res == -2) {
                apply_autostash(opts);
                sequencer_remove_state(opts);
 
                return -1;
-       }
-
-       strbuf_stripspace(&new_todo.buf, 1);
-       if (new_todo.buf.len == 0) {
+       } else if (res == -3) {
                apply_autostash(opts);
                sequencer_remove_state(opts);
                todo_list_release(&new_todo);
-- 
2.19.1.872.ga867da739e

Reply via email to