On Thu, Nov 29, 2018 at 7:14 PM Stefan Beller <sbel...@google.com> wrote: > > > > Idea: > > > If git checkout-files modifies the submodules file, it could also > > > auto-update the submodules. (For example, with something like "git > > > submodule update --init --recursive --progress"). > > > > This one is tricky because we should deal with submodule autoupdate > > consistently across all porcelain commands (or at least common ones), > > not just checkout-files. I'd prefer to delay this until later. Once we > > figure out what to do with other commands, then we can still change > > defaults for checkout-files. > > checkout/reset are respecting the submodule.recurse setting for this > already, and as your patches only change the UX frontend > > git -c submodule.recurse checkout-files <pathsspec> > > would also touch submodules. Given that deep down in > the submodules it's all about files again, we could think > checkout-files is still a good name. > > I think Stefan X. is asking for making submodule.recurse > to default to true, which is indeed unrelated to this.
Yes and I'm concerned that checkout-files now recurses into submodules this by default but grep for example does not. That just adds more confusion. -- Duy
