Hi Steven, please stop dropping me from the Cc: list. Thanks.
On Fri, 7 Dec 2018, Steven Penny wrote: > On Fri, Dec 7, 2018 at 11:04 AM wrote: > > > The solution is to implement has_dos_drive_prefix(), > > skip_dos_drive_prefix() is_dir_sep(), offset_1st_component() and > > convert_slashes() for cygwin in the same way as it is done in 'Git for > > Windows' in compat/mingw.[ch] > > > > Instead of duplicating the code, it is extracted into > > compat/mingw-cygwin.[ch] Some need for refactoring and cleanup came up > > in the review, they are adressed in a seperate commit. > > i have applied the 3 patches against current master, and my original > test passes, so looks good to me. > > however like Johannes i take issue with the naming. as he said "mingw-cygwin" > really isnt appropriate. ideally it would be "windows.h", but as that is > conspicuously in use, something like these: > > - pc-windows > - pc-win > - win I find all of those horrible. > i disagree with him on using "win32" - that doesnt really make sense, ... except if you take into account that this has been our convention for, what, almost 9 years (since 44626dc7d5 (MSVC: Windows-native implementation for subset of Pthreads API, 2010-01-15), to be precise)? In that case, it makes a ton of sense, and one might be tempted to ask who the person wanting to change that thinks they are... > as obviously you can compile 64-bit Git for Windows. if you wanted to go > that route you would want to use something like: > > - windows-api > - win-api > - winapi > > further - i disagree with the "DOS" moniker being used at all. DOS is a > defunkt operating system that i dont think Git has *ever* supported, so > it doesnt make sense to be referring to it this way. again, a more > approriate name would be something like "win_drive_prefix". You may disagree all you want, but given that Torsten has been a lot more active on this code than you have been so far, I'll go with Torsten's taste. Which incidentally happens to match my tastes, so that's an added bonus. Ciao, Johannes
