Brandon Casey <draf...@gmail.com> writes: > On Tue, Jan 22, 2013 at 12:38 AM, Jonathan Nieder <jrnie...@gmail.com> wrote: >> Brandon Casey wrote: >> >>> Teach append_signoff how to detect a duplicate s-o-b in the commit footer. >>> This is in preparation to unify the append_signoff implementations in >>> log-tree.c and sequencer.c. >> [...] >>> --- a/sequencer.c >>> +++ b/sequencer.c >>> @@ -1082,9 +1101,10 @@ int sequencer_pick_revisions(struct replay_opts >>> *opts) >>> return pick_commits(todo_list, opts); >>> } >>> >>> -void append_signoff(struct strbuf *msgbuf, int ignore_footer) >>> +void append_signoff(struct strbuf *msgbuf, int ignore_footer, int >>> no_dup_sob) >> >> Isn't the behavior of passing '1' here just a bug in "format-patch -s"? > > I think that is an open question.
Yes. as I said in a previous review round, I think it was a mistake that format-patch chose to pay attention to any S-o-b in the patch trail, not only the last one, and we may want to correcct it once this series solidifies as a separate "bugfix" change on top. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
