Brandon Casey wrote:

[...]
> --- a/t/t4014-format-patch.sh
> +++ b/t/t4014-format-patch.sh
> @@ -1021,4 +1021,246 @@ test_expect_success 'cover letter using branch 
> description (6)' '
>       grep hello actual >/dev/null
>  '
>  
> +append_signoff()
> +{
> +     C=`git commit-tree HEAD^^{tree} -p HEAD` &&
> +     git format-patch --stdout --signoff ${C}^..${C} |
> +             tee append_signoff.patch |
> +             sed -n "1,/^---$/p" |
> +             grep -n -E "^Subject|Sign|^$"
> +}

Is "grep -n" portable?  I didn't find any uses of it elsewhere in the
testsuite.

Style: checking exit status from format-patch, avoiding sed|grep pipeline:

        C=$(git commit-tree HEAD^ -p HEAD) &&
        git format-patch --stdout --signoff $C^..$C >append_signoff.patch &&
        awk '
                /^---$/ { exit; }
                /^Subject/ || /^Sign/ || /^$/ { print NR ":" $0 }
        ' <append_signoff.patch >actual
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to