Hi Stolee, On Fri, 17 May 2019, Derrick Stolee via GitGitGadget wrote:
> In Windows, the way we rename a lock file to replace the underlying file > does not work when a process holds a read handle. For this reason, we call > close_all_packs() everywhere before starting a git gc --auto subprocess. We > also call close_commit_graph() before renaming the commit-graph lock file. > But we don't close the commit-graph handles before running gc, which can > cause an issue when gc.writeCommitGraph is enabled. > > This series adds close_commit_graph() to close_all_packs() and then renames > close_all_packs() to close_object_store(). This name is more descriptive of > its larger purpose. > > This is based on ds/commit-graph-write-refactor to avoid conflicts. Thank you so much for jumping on my (off-list, in-team) bug report! FWIW I integrated this series into Git for Windows v2.22.0-rc1 already. Thanks, Dscho
