On Tue, Feb 12, 2013 at 03:02:31PM +0100, Michal Nazarewicz wrote:
> sub command_close_bidi_pipe {
> local $?;
> my ($self, $pid, $in, $out, $ctx) = _maybe_self(@_);
> - _cmd_close($ctx, $in, $out);
> + _cmd_close($ctx, grep defined, $in, $out);
Maybe it is just me, but I find the "grep EXPR" form a little subtle
inside an argument list. Either:
_cmd_close($ctx, grep { defined } $in, $out);
or
_cmd_close($ctx, grep(defined, $in, $out));
is a little more obvious to me.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
