On Thu, Sep 5, 2019 at 12:01 PM SZEDER Gábor <szeder....@gmail.com> wrote: > > On Thu, Sep 05, 2019 at 08:47:23AM -0700, Elijah Newren wrote: > > This patch series fixes a few issues with git-clean: > > > * Failure to preserve both tracked and untracked files within a nested > > Git repository reported a few weeks ago by SZEDER[3]. > > Wow, I didn't expect a 12 patch series to fix that issue... > Thanks.
Well, to be fair, only the last three patches were about that issue. The first 9 were about the other issues. It's just that your testcase reminded me of my old series and gave me another nudge to dig it out and see if it helped with your problem. I had to rebase it and look back over it, and then found it didn't help with your problem, but by then I had refamiliarized myself with the code so... > > Elijah Newren (12): > > t7300: Add some testcases showing failure to clean specified pathspecs > > dir: fix typo in comment > > dir: fix off-by-one error in match_pathspec_item > > dir: Directories should be checked for matching pathspecs too > > dir: Make the DO_MATCH_SUBMODULE code reusable for a non-submodule > > case > > dir: If our pathspec might match files under a dir, recurse into it > > Nit: no capital letters after the '<area>:' prefix. Gah, I should know that any patch series I submitted from a year and a half ago probably made that mistake. I've mostly trained myself out of it now, but I certainly hadn't back then. Thanks for pointing it out; will fix.
