One minor nitpick: please add a comment at the top of the file
documenting the `--title` option, and the usage of the program in
general.
Other than that, looks good. Thanks.
On 26/09/19 08:29AM, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <johannes.schinde...@gmx.de>
>
> "Question?" is maybe not the most informative thing to ask. In the
> absence of better information, it is the best we can do, of course.
>
> However, Git for Windows' auto updater just learned the trick to use
> git-gui--askyesno to ask the user whether to update now or not. And in
> this scripted scenario, we can easily pass a command-line option to
> change the window title.
>
> So let's support that with the new `--title <title>` option.
>
> Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de>
> ---
> git-gui--askyesno | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/git-gui--askyesno b/git-gui--askyesno
> index cf9c990d09..45b0260eff 100755
> --- a/git-gui--askyesno
> +++ b/git-gui--askyesno
> @@ -12,10 +12,15 @@ if {$use_ttk} {
> set NS ttk
> }
>
> +set title "Question?"
> if {$argc < 1} {
> puts stderr "Usage: $argv0 <question>"
> exit 1
> } else {
> + if {$argc > 2 && [lindex $argv 0] == "--title"} {
While this is probably not the most robust way of handling command line
arguments, I guess it doesn't really make too much of a difference for
something this simple.
> + set title [lindex $argv 1]
> + set argv [lreplace $argv 0 1]
> + }
> set prompt [join $argv " "]
> }
>
> @@ -47,5 +52,5 @@ proc yes {} {
> exit 0
> }
>
> -wm title . "Question?"
> +wm title . $title
> tk::PlaceWindow .
> --
> gitgitgadget
>
--
Regards,
Pratyush Yadav
