On 04/10/19 10:49AM, Johannes Schindelin wrote: > Hi Pratyush, > > please don't top-post on this list (yet another of these things > requiring extra brain cycles in the mailing list workflow).
I didn't top-post, or at least it wasn't the intention. The text above the quoted text is the "preface" (just like this line I'm replying to is a "preface"). It was a comment on the patch formatting, and it wouldn't make sense (at least to me) to have it _below_ the quoted part, especially since I did have comments in-line (IOW, bottom-posted). Maybe because I included the references in the middle of the text you thought the message was over (understandably so. I probably shouldn't do that), and didn't scroll till the end to read the rest of the message. Or maybe I don't know something about email etiquette that I should. > On Fri, 4 Oct 2019, Pratyush Yadav wrote: > > > Hi Harish, > > > > Thanks for the patch. Unfortunately, it seems your mail client messed up > > the formatting, and the patch won't apply. I'm guessing it is because > > your mail client broke long lines into two, messing up the diff. > > > > We use an email-based workflow, so please either configure your mail > > client so it doesn't munge patches, or use `git send-email`. You can > > find a pretty good tutorial on sending patches via email over at [0]. > > The tutorial is for git.git, but works for git-gui.git as well. > > Ah, well. Mailing list-based workflows are so easy, amirite? They are so > welcoming and inclusive, yes? > </sarcasm> > > > If you feel more comfortable with GitHub pull requests, please take a > > look at Gitgitgadget [1]. Johannes (in Cc) has used it recently to send > > patches based on the git-gui repo (AFAIK, it was originally designed > > only for the git.git repo). Maybe ask the folks over there how they do > > it. > > Harish, it is actually relatively easy to use GitGitGadget: just add a > remote like this: > > git remote add gitgitgadget https://github.com/gitgitgadget/git > git fetch gitgitgadget git-gui/master > > and then rebase your patch on top of that branch: > > git rebase -i --onto git-gui/master HEAD~1 > > Then force-push your branch to your GitHub fork of git.git and open a > Pull Request at https://github.com/gitgitgadget/git/pulls, targeting > git-gui/master. > > GitGitGadget will welcome you with a (hopefully) helpful message ;-) Thanks for these instructions. I will include them in a "Contributing" document I'm writing for git-gui. -- Regards, Pratyush Yadav
