On Thu, Feb 21, 2013 at 10:51 AM, Junio C Hamano <gits...@pobox.com> wrote: > Brandon Casey <draf...@gmail.com> writes: > >> Teach append_signoff to detect whether a blank line exists at the position >> that the signed-off-by line will be added, and refrain from adding an >> additional one if one already exists. Or, add an additional line if one >> is needed to make sure the new footer is separated from the message body >> by a blank line. >> >> Signed-off-by: Brandon Casey <bca...@nvidia.com> >> --- >> >> >> A slight tweak. And I promise, no more are coming. > > When I do > > $ git commit -s > > it should start my editor with this in the buffer: > > ---------------------------------------------------------------- > > Signed-off-by: Junio C Hamano <gits...@pobox.com> > ---------------------------------------------------------------- > > and the cursor blinking at the beginning of the file. Annoyingly > this step breaks it by removing the leading blank line.
Yes. The fix described by John Keeping restores the above behavior for 'commit -s'. Or the fix I described which inserts two preceding newlines so it looks like this: ---------------------------------------------------------------- Signed-off-by: Junio C Hamano <gits...@pobox.com> ---------------------------------------------------------------- So then the cursor would be placed on the first line and a space would separate it from the sob which is arguably a better indication to the user that a blank line should separate the commit message body from the sob. But, this does not fix the same problem for 'cherry-pick --edit -s' when used to cherry-pick a commit without a sob. The cherry-pick part of it would add the extra preceding newlines, but then cherry-pick passes the buffer to 'git commit' via .git/MERGE_MSG which then "cleans" the buffer, removing the empty lines, in prepare_to_commit() before allowing the editor to operate on it. Using 'cherry-pick --edit -s' to cherry-pick a commit with an empty commit message is going to be a pretty rare corner case. It would be nice to have the same behavior for it that we decide to have for 'commit -s', but it's probably not worth going through contortions to make it happen. -Brandon -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
