Junio C Hamano <gits...@pobox.com> writes: > In other words, with the new world order, wouldn't a saner function > signature be: > > static const char *read_and_strip_branch(const char **path);
Eh, discard an asterisk from there. "Given a string to name the file, read it to find the branch name recorded in it". > after this patch? > > Also I notice that the error-return cases of this function may be > wrong even before your patch. Shouldn't it be doing *branch = NULL > (and 'return NULL' after the suggested change)? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
