Andrew Wong <andrew.k...@gmail.com> writes: > On 3/7/13, Junio C Hamano <gits...@pobox.com> wrote: >> This did not error out for me, though. >> >> $ cd t && git ls-files ":(top" > > No error message at all? Hm, maybe in your case, the byte after the > end of string happens to be '\0' and the loop ended by chance? > > git doesn't crash for me, but it generates this error: > $ git ls-files ":(top" > fatal: Invalid pathspec magic 'LS_COLORS=' in ':(top'
What I meant was that I do not get any error _after_ applying your patch. It is broken to behave as if "LS_COLORS=..." (which is totally unrelated string that happens to be laid out next in the memory) is a part of the pathspec magic specification your ":(top" started. Your patch makes the code stop doing that. But it is equally broken to behave as if there is nothing wrong in the incomplete magic ":(top" that is not closed, isn't it? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
