>> By the way, if we know the length of the string, we could use memcmp. >> This one is allowed to compare 4-bytes at a time (he doesn't care >> about end of string). This is true because the value of the length >> parameter is no longer "at most". > > We still need to worry about access violation after NUL when two > strings have different lengths. That could be avoided in this > particular case, but I think it's too fragile.
Why would we need to compare if the strings don't have the same length ? We already do that in combine-diff.c:append_lost(). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
