Re: [PATCH 1/6] remote.c: simplify a bit of code using git_config_string()

[Jonathan Nieder]

Ramkumar Ramachandra wrote:

> --- a/remote.c
> +++ b/remote.c
> @@ -356,9 +356,7 @@ static int handle_config(const char *key, const char 
> *value, void *cb)
>                       return 0;
>               branch = make_branch(name, subkey - name);
>               if (!strcmp(subkey, ".remote")) {
> -                     if (!value)
> -                             return config_error_nonbool(key);
> -                     branch->remote_name = xstrdup(value);
> +                     git_config_string(&branch->remote_name, key, value);

Shouldn't this say

                        if (git_config_string(&branch->remote_name, key, value))
                                return -1;

or something?

Thanks,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html