On Fri, Mar 22, 2013 at 6:36 PM, John Szakmeister <j...@szakmeister.net> wrote: > On Fri, Mar 22, 2013 at 12:19 PM, Timo Sand <timo.j.s...@gmail.com> wrote: >> Hi, >> >> well my use case is actually that I'm trying to use the gem >> 'gem-browse' which uses 'git web--browse' >> I'm not using Apple Terminal, I'm using iTerm2 and there doesn't seem >> to be a SECURITYSESSIONID set, at least echo didn't find any. But >> neither did I find it on Apple Terminal either. > > I noticed this the other day, but I think SECURITYSESSIONID only gets > set when Screen Sharing is enabled. I had Screen Sharing enabled, > launched iTerm2 and saw the variable. I closed iTerm2, turned off > Screen Sharing, and relaunched iTerm2 to find the variable missing. > As a result, I'm not SECURITYSESSIONID is a good mechanism for > determining whether the terminal is associated a GUI or not. > Unfortunately, I don't know of a better way. > >> What troubles me is that this issue has only arisen recently, earlier >> this worked fine for me > > The following patch fixes the issue by recognizing iTerm2 as a GUI terminal.
Your patch looks good to me, and I cannot really test it as I don't have a Mac. Could you just had some of the explanations you gave above to the commit message? Thanks, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
