Felipe Contreras <felipe.contre...@gmail.com> writes: > It's wrong to call get_sha1() if they should be SHA-1s, plus > inefficient. > > Signed-off-by: Felipe Contreras <felipe.contre...@gmail.com> > ---
It appears that "they should be SHA-1s" assumption does not hold; this patch breaks at least 3303, 9020, and 9300. Also assuming these are always 40-hex goes directly against what is documented in Documentation/git-fast-import.txt (look for "Here committish is any of the following"). My bad while reviewing the earlier round. I've redone 'pu' (which was failing the test last night) after dropping this and keeping only patches 2 and 3 from the series. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
