On Wed, May 29, 2013 at 8:46 PM, Felipe Contreras <felipe.contre...@gmail.com> wrote: > On Wed, May 29, 2013 at 8:42 AM, Duy Nguyen <pclo...@gmail.com> wrote: >> On Wed, May 29, 2013 at 8:34 PM, Felipe Contreras >> <felipe.contre...@gmail.com> wrote: >>> On Wed, May 29, 2013 at 8:25 AM, Duy Nguyen <pclo...@gmail.com> wrote: >>>> On Mon, May 27, 2013 at 11:52 PM, Felipe Contreras >>>> <felipe.contre...@gmail.com> wrote: >>>>> We should free objects before leaving. >>>>> >>>>> Signed-off-by: Felipe Contreras <felipe.contre...@gmail.com> >>>> >>>> Micronit: perhaps you should move the "free obejcts before leaving" >>>> (in do_pick_commit) to the subject instead of "trivial fix", which >>>> adds no value to the patch. >>> >>> Perhaps. I prefer it this way because it's really a trivial fix not >>> really worth much time thinking about it. So when somebody is browsing >>> the history they can happily skip this one. The time save by not >>> reading I think adds more value than any succinct description that >>> would force each and every patch-reviewer/history-reader to read it. >> >> Some time from now, assume a ridiculus case when this function grows >> more complex and somebody wonders what the "leave" label is for, "git >> log --oneline -Slabel:" showing "trivial fix" would not help much. > > Fortunately that's not the main use-case, and for that single instance > that probably will never happen, I think it's not too much to ask to > this hypothetical developer to remove the --oneline, or copy-paste the > SHA-1 and take a peek. He would probably need to do that anyway.
And the "time saving by not reading" is also hypothetical. But I won't continue this discussion. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
