On Sun, Jun 2, 2013 at 5:08 PM, Junio C Hamano <gits...@pobox.com> wrote: > Felipe Contreras <felipe.contre...@gmail.com> writes: > >> It's _very_ slow in many cases, and there's really no point in fetching >> *everything* from the remote just for completion. In many cases it might >> be faster for the user to type the whole thing. > > Besides, if I understand the use of __git_refs correctly, it is > primarily about completing things like > > git checkout -b topic origin/<TAB> > > where you actively want _local_ copies of what you currently have in > refs/remotes/origin/, not what you would get if you were to fetch > and then type the command again, so in that sense, using ls-remote > is a wrong thing to do in the first place.
Yeah, but we wouldn't use ls-remote in those cases, only when __gitdir is not available. Try 'git checkout <TAB>' outside a git repository. > This however may need to be made optional if this is also being used > to complete > > git fetch git://g.k.org/pub/scm/git/git.git/ <TAB> > > to list what can be fetched, but I do not think that is a very > common thing to do (you either know what you want to fetch, in which > case you do not complete but copy & paste, or more likely you have a > named remote and fetch the whole thing). Indeed. And it doesn't make sense to punish the typical use-cases because of the atypical ones. Besides: git fetch git://g.k.org/pub/scm/git/git.git/ refs/<TAB> Would still complete everything. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
