Felipe Contreras <felipe.contre...@gmail.com> writes: > On Sun, Jun 9, 2013 at 2:20 PM, Junio C Hamano <gits...@pobox.com> wrote: >> Felipe Contreras <felipe.contre...@gmail.com> writes: >> >>> On Sun, Jun 9, 2013 at 1:30 PM, Junio C Hamano <gits...@pobox.com> wrote: >>> >>>> --- a/t/test-lib-functions.sh >>>> +++ b/t/test-lib-functions.sh >>>> @@ -606,6 +606,18 @@ test_cmp() { >>>> $GIT_TEST_CMP "$@" >>>> } >>>> >>>> +# Check if the file expected to be empty is indeed empty, and barfs >>>> +# otherwise. >>>> + >>>> +test_output_must_be_empty () { >>> >>> Why such a big name? test_empty() does the trick. >> >> Primarily in order to avoid that exact name "test_empty" that others >> may want to use for a helper to check that the contents of a string >> variable is empty. > > Which is never going to happen.
For anything, a failure from test -z "$mustbeemptystring" in the test suite is much harder to diagnose because there is nothing left in the trash directory to inspect, as opposed to test ! -s "$mustbeemptyfile" where you can just go there and inspect yourself. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html