On Tue, Jun 11, 2013 at 11:10 AM, Thomas Rast <tr...@inf.ethz.ch> wrote: > Michael Haggerty <mhag...@alum.mit.edu> writes: > >> * Accept reviewers' comments gratefully and take them very seriously. >> Show that you appreciate the help by giving the reviewer the benefit of >> the doubt. If, after careful consideration, you find that you cannot >> agree with a reviewer's suggestion, explain your reasoning carefully >> without taking or giving offense, and seek compromise. > > I'm not sure yet how to phrase it, but I have come to the conclusion > that the dual nature of reviews is part of the problem. > > On the one hand, reviews are code criticism: they are extra work spent > by the reviewer to try and help you improve your work. > > On the other hand, they are also quality checks. Reviews serve to spot > bugs, misdesigns, noncompliance with project standards, etc. before they > ever go into the code base. > > The problems start when these start having a contradictory impact on the > correct course of action in a discussion, or in the longer term in > dealing with a person. For example, I have attempted to deal with > Felipe at one point by refusing to review, i.e., ignore the email. > > However, this must be weighed against the requirements of the second > kind of review. So while it is exceedingly easy for everyone to say > "just ignore the flamebait", the flamewars keep recurring because this > "gatekeeper" type of review continues to be necessary, and continues to > elicit nonconstructive responses.
Why do you assume the review is for the patch submitter? You can reply so your review is stored on the record, and the maintainer, Junio, can see it. Then you can ignore the fallout. I think this type of review is hurtful, because the fact that you said some words doesn't mean you are right, and you might be blocking a perfectly good patch by not following up the counter arguments. Presumably you are not worried about that, and you would be content with simply blocking all my patches. Whatever floats your boat. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
