On Thu, Jul 04, 2013 at 11:47:04PM -0700, Junio C Hamano wrote: > Alexey Shumkin <alex.crez...@gmail.com> writes: > > > This is actually a fixup of de6029a2d7734a93a9e27b9c4471862a47dd8123, > > which was applied before final patch series was sent. > > > > Also, see 3994e8a98dc7bbf67e61d23c8125f44383499a1f for the explanation > > of such a replacement. > > These are not very useful in a log message. People who read the > history 6 months down the road would want to see why we want to use > iso8859-1 not iso-8859-1 explained. > > Both "iso8859-1" and "iso-8859-1" are understood as latin-1 > by modern platforms, but the latter is not understood by > older platforms;update tests to use the former. > > This is in line with 3994e8a9 (t4201: use ISO8859-1 rather > than ISO-8859-1, 2009-12-03), which did the same. Yep, it whould be better, I thought to do like this but I didn't ) > > > Signed-off-by: Alexey Shumkin <alex.crez...@gmail.com> > > Reviewed-by: Johannes Sixt <j.s...@viscovery.net> > > I do not recall this exact patch reviewed by J6t, but perhaps I > missed a message on the list? I've reread 'SubmittingPatches' doc, and I can say I used "Reviewed-by" incorrectly. Sorry for this. It must be "Suggested-by" there, I guess.
-- Alexey Shumkin -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
