Matthieu Moy wrote: > That would mean executing SOMETEXTTOEXECUTE each time the config file is > read. This raises two issues: > > * A security issue, as SOMETEXTTOEXECUTE could also be something > dangerous. It would not be much worse than the current situation (if > your config file is not trusted, then an attacker could put malicious > code in core.editor for example), but still increase the security > risk (as any command reading the config may trigger execution).
I don't think the security issue is too bad. As you say, the combination of control over core.pager and pager.config is already pretty dangerous. > * A performance issue with the current git implementation, as the config > file may be read many time for a single git execution. This issue is harder. >> Is this a feature others could get behind? > > I think it's unlikely that this ever be implemented. What I suggest > instead is to edit/track/share template configuration files like > > ~/.gitconfig.in > email = me@HOSTNAME@ > > and then script something like sed -e "s/@HOSTNAME@/$(hostname)/" < > ~/.gitconfig.in > ~/.gitconfig. Yeah, substitution scripts like this are probably the simplest way to go. Maybe some day it will make sense for commands to check the timestamp or checksum of <foo>.in to automatically regenerate <foo> on the fly when <foo>.in and other inputs change, but that sounds like more complication than it's worth for git to take on. Other alternatives might be to do that on the filesystem level (a FUSE filesystem or Hurd-style translator generating determining the read(2) result for <foo> on the fly), the editor level (vi knowing to regenerate <foo> when you save <foo>.in), or the session management level (bash via ~/.profile or ~/.bashrc or pam-login regenerating <foo> at the start of each interactive session). I wish there were an standard way to deal with such tasks instead of running an update script manually, but now I'm getting off topic. Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
