On Wed, Aug 28, 2013 at 4:21 PM, Felipe Contreras <felipe.contre...@gmail.com> wrote: > On Wed, Aug 28, 2013 at 3:54 PM, Antoine Pelisse <apeli...@gmail.com> wrote: >> On Wed, Aug 28, 2013 at 10:48 PM, Felipe Contreras >> <felipe.contre...@gmail.com> wrote: >>> On Wed, Aug 28, 2013 at 3:05 PM, Matthieu Moy >>> <matthieu....@grenoble-inp.fr> wrote: >>>> Felipe Contreras <felipe.contre...@gmail.com> writes: >>>> >>>>> + echo greg >> content && >>>>> + git add content && >>>>> + git commit -m one >>>> >>>> test_commit would make it shorter. >>> >>> And it would make it inconsistent with the rest of the script. >>> >>>>> + bzr log | grep "^committer: " > ../actual >>>>> + ) && >>>>> + >>>>> + echo "committer: Grégoire <commit...@example.com>" > expected && >>>> >>>> Git's source code usually says >../actual and >expected, without space >>>> after '>'. >>> >>> Not that usually: >>> >>> % git grep ' > ' t/*.sh | wc -l >>> 1943 >> >> There are many false positive in that count. >> >> As in this one: >> $ git grep ' >[^ ]' -- t/*.sh | wc -l >> 10354 > > Ten thousand is still a lot, and the claim remains: it's far from > unusual to follow this style.
Er, I read that command wrong, but whatever the actual number is, the point is that there's a lot. In fact, I could only count 43 false positives in that command: t/annotate-tests.sh:test_expect_success 'blame -L X (X > nlines)' ' t/annotate-tests.sh:test_expect_success 'blame -L ,Y (Y > nlines)' ' t/lib-diff-alternative.sh: if(n > 1) t/lib-diff-alternative.sh: if(n > 2) t/lib-diff-alternative.sh:+ if(n > 2) t/lib-diff-alternative.sh:- if(n > 1) t/t3800-mktag.sh: > 0 +0000 t/t4041-diff-submodule-option.sh: > Add foo3 ($added foo3) t/t4041-diff-submodule-option.sh: > Add foo3 ($added foo3) t/t4041-diff-submodule-option.sh: > Add foo3 ($added foo3) t/t4041-diff-submodule-option.sh: > Add foo5 ($added foo5) t/t4041-diff-submodule-option.sh: > Add foo4 ($added foo4) t/t4041-diff-submodule-option.sh: > change t/t4041-diff-submodule-option.sh: > change t/t4041-diff-submodule-option.sh: > change t/t4041-diff-submodule-option.sh: > change t/t4041-diff-submodule-option.sh: > change t/t4041-diff-submodule-option.sh: > change t/t4041-diff-submodule-option.sh: > change t/t4041-diff-submodule-option.sh: > change t/t7401-submodule-summary.sh: > Add foo2 t/t7401-submodule-summary.sh: > Add foo2 t/t7401-submodule-summary.sh: > Add foo2 t/t7401-submodule-summary.sh: > Add foo3 t/t7401-submodule-summary.sh: > Add foo3 t/t7401-submodule-summary.sh: > Add foo5 t/t7401-submodule-summary.sh: > Add foo4 t/t7401-submodule-summary.sh: > Add foo5 t/t7401-submodule-summary.sh: > Add foo4 t/t7401-submodule-summary.sh: > Add foo5 t/t7401-submodule-summary.sh: > Add foo7 t/t7401-submodule-summary.sh: > Add foo9 t/t7401-submodule-summary.sh: > Add foo9 t/t7401-submodule-summary.sh: > Add foo9 t/t7401-submodule-summary.sh:# > Add foo9 t/t7508-status.sh:# > Add foo t/t7508-status.sh:# > Add foo t/t7508-status.sh:# > Add bar t/t7508-status.sh:# > Add bar t/t7508-status.sh:# > Add bar t/t7508-status.sh:# > 2nd commit t/t7508-status.sh:; > Add bar t/t7508-status.sh:; > 2nd commit -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
