[Ævar, sorry for duplication but I accidentally send HTML email; stupid Gmail]
On Thu, Aug 29, 2013 at 4:26 PM, Ævar Arnfjörð Bjarmason
<ava...@gmail.com> wrote:
> The @author_initials feature Jakub added in a36817b claims to use a
> i18n regexp (/\b([[:upper:]])\B/g), but in Perl this doesn't actually
> do anything unless the string being matched against has the UTF8 flag.
>
> So as a result it abbreviates me to "AB" not "ÆAB".
[...]
Thanks for catching this, and for an analysis.
> Jakub, do you see a reason not to just apply this:
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index f429f75..29b3fb5 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -6631,6 +6631,7 @@ sub git_blame_common {
> $hash_base, '--', $file_name
> or die_error(500, "Open git-blame --porcelain
> failed");
> }
> + binmode $fd, ":utf8";
>
> # incremental blame data returns early
> if ($format eq 'data') {
>
> I haven't gotten an env where I can test gitweb running, but that
> looks like it should work to me.
Unfortunetly I cannot check this either, but it looks obviously correct.
ACK.
--
Jakub Narebski
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
